Update dataset editor file browser modal to use spx theme css#292
Merged
klpoland merged 11 commits intoJun 25, 2026
Conversation
klpoland
added
feature
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
lucaspar
reviewed
Jun 4, 2026
klpoland
force-pushed
the
feature-kpoland-enhanced-dataset-editor-file-browser
branch
from
a430e87 to
8e6ebdb
Compare
lucaspar
approved these changes
Jun 11, 2026
Collaborator
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…ad of template literals
klpoland
force-pushed
the
feature-kpoland-enhanced-dataset-editor-file-browser
branch
from
147463f to
f0926b8
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3becbf6. Configure here.
klpoland
deleted the
feature-kpoland-enhanced-dataset-editor-file-browser
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches core dataset create/edit file selection UI and pending-change behavior; no API contract changes, but regressions could affect which files are submitted or how removals display before save.
Overview
Replaces the dataset file picker modal table (
#file-tree-table) with a SpectrumX-themed accessible tree (#file-tree-rootinside.file-browser-modal), including click-to-select rows, visually hidden checkboxes, keyboard activation, and modal-specific styling.Selection behavior is consolidated in
AssetSearchHandler: modal picks live inselectedFilesuntil confirm, with folder selection mode (toggle all selectable files in a directory), clear modal selections, select-all, andsyncCommittedFileSelectionUIfor the summary field and create-mode selected-files table. The tree is built with DOM APIs andtextContentfor names instead of HTML string rows.DatasetCreationHandlerandDatasetEditingHandlerdrop duplicate modal/checkbox logic and delegate to the search handler; edit mode gains pending file removal styling synced on tree rebuild, normalized file IDs,removeAllFileSelections, and an Enter key guard on the dataset form. Tests and a frontend rule note are updated accordingly.Reviewed by Cursor Bugbot for commit 3becbf6. Bugbot is set up for automated code reviews on this repo. Configure here.